Add tests to PPS Source Activate function #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D62447639 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D62447639 |
crmdias
added a commit
to crmdias/time
that referenced
this pull request
Sep 12, 2024
Summary: Pull Request resolved: facebook#395 WHAT? Adds tests to ActivatePPSSource function WHY? Ensuring functional correctnes, ensuring edge cases work and making the code more maintainable for the future Considerations: That's a lot of code! - Yeah, but it is necessary to do the rigging for testing the syscalls Why do you have machBy with return true? - To dereference the pointer of the struct passed as argument, and then assert it with require.Equals, which gives nice comparison logs Reviewed By: leoleovich Differential Revision: D62447639
crmdias
force-pushed
the
export-D62447639
branch
from
1c253c4 to
86ba66e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62447639 |
crmdias
force-pushed
the
export-D62447639
branch
from
86ba66e to
81272c6
Compare
Summary: Pull Request resolved: facebook#395 WHAT? Adds tests to ActivatePPSSource function WHY? Ensuring functional correctnes, ensuring edge cases work and making the code more maintainable for the future Considerations: That's a lot of code! - Yeah, but it is necessary to do the rigging for testing the syscalls Why do you have matchBy with return true? - To dereference the pointer of the struct passed as argument, and then assert it with require.Equals, which gives nice comparison logs Reviewed By: leoleovich Differential Revision: D62447639
|
This pull request was exported from Phabricator. Differential Revision: D62447639 |
crmdias
force-pushed
the
export-D62447639
branch
from
81272c6 to
b41cacc
Compare
|
This pull request has been merged in 4d61e17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
WHAT?
Adds tests to ActivatePPSSource function
WHY?
Ensuring functional correctnes, ensuring edge cases work and making the code more maintainable for the future
Considerations:
That's a lot of code!
Why do you have machBy with return true?
Reviewed By: leoleovich
Differential Revision: D62447639